Skip to content

Fix Heartbeat Response V1+ field ordering #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Heartbeat Response V1+ field ordering #1371

wants to merge 1 commit into from

Conversation

jessekempf
Copy link
Contributor

https://kafka.apache.org/11/protocol.html#The_Messages_Heartbeat

The V0 heartbeat response looks like:

Heartbeat Response (Version: 0) => error_code 
  error_code => INT16

The V1 heartbeat response looks like:

Heartbeat Response (Version: 1) => throttle_time_ms error_code 
  throttle_time_ms => INT32
  error_code => INT16

This change makes it so that the V1 heartbeat responses no longer have the error code mistakenly reported as a time.Duration.

@jessekempf jessekempf force-pushed the heartbeat-response-field-ordering branch from fe52caf to 7d2b040 Compare June 9, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jessekempf